xl: fix broken cpupool-numa-split
authorJuergen Gross <juergen.gross@ts.fujitsu.com>
Fri, 28 Jan 2011 17:41:15 +0000 (17:41 +0000)
committerJuergen Gross <juergen.gross@ts.fujitsu.com>
Fri, 28 Jan 2011 17:41:15 +0000 (17:41 +0000)
The implementation of xl cpupool-numa-split is broken.  It adds nodes
to the wrong pool.  This was probably a copy and paste error which
happened when libxl_cpupool_cpuadd_node() was introduced.

Reported-by: Andre Przywara <andre.przywara@amd.com>
Signed-off-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/xl_cmdimpl.c

index 5826755ee69cbe89dc755184259aaed52193978a..eded63700eb1711ae9fc562f8ecafbda83edb1e4 100644 (file)
@@ -5825,7 +5825,7 @@ int main_cpupoolnumasplit(int argc, char **argv)
             goto out;
         }
 
-        ret = -libxl_cpupool_cpuadd_node(&ctx, 0, node, &n);
+        ret = -libxl_cpupool_cpuadd_node(&ctx, poolid, node, &n);
         if (ret) {
             fprintf(stderr, "error on adding cpus to cpupool\n");
             goto out;